test(credential-provider-node): remove sts and sso client mocks #6619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
commented
Nov 4, 2024
| $source: { | ||
| CREDENTIALS_PROFILE_SOURCE_PROFILE: "o", | ||
| CREDENTIALS_STS_ASSUME_ROLE: "i", | ||
| }, | ||
| }); | ||
| }); | ||
|
|
||
| xit("should prefer static credentials over role assumption metadata only if the profile is not the first one visited", async () => { | ||
| // TODO | ||
| }); |
There was a problem hiding this comment.
This test case isn't necessary, because other tests cover it.
I wrote this initially when I was going over the default credential provider chain and it looked like a distinct use-case, but isn't.
trivikr
approved these changes
Nov 4, 2024
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Mocking of STS caused a bug in https://github.com/aws/aws-sdk-js-v3/releases/tag/v3.667.0 to not be caught.
Description
Removes the mocking of the STS and SSO clients in the credential provider chain's integration test. The mocking is moved to the HTTP Handler level.
Testing
CI / running these integration tests.
Verifying that this would've caught the issue in v3.667.0: