Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: package.json homepage links to use the main branch #6336

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

chad3814
Copy link
Contributor

Description

So with the fast-xml-parser vulnerability I was trying to trace down if updating would help, and I started at the npm package page for @aws-sdk/core. The homepage link was out of date and led to a 404.

I looked at the package.json files in clients/* and packages/* looking for homepage values not using the main branch, and corrected them to main.

Testing

No code testing, a documentation change.

Checklist

  • If you wrote E2E tests, are they resilient to concurrent I/O?
  • If adding new public functions, did you add the @public tag and enable doc generation on the package?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@chad3814 chad3814 requested a review from a team as a code owner July 30, 2024 16:57
@trivikr trivikr changed the title Fix homepage links to use the main branch instead of master fix: package.json homepage links to use the main branch Jul 30, 2024
@trivikr trivikr merged commit e332230 into aws:main Jul 30, 2024
4 of 5 checks passed
@chad3814 chad3814 deleted the npm-links branch July 30, 2024 17:29
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants