Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Glacier migration #485

Merged
merged 6 commits into from
Dec 5, 2019
Merged

Glacier migration #485

merged 6 commits into from
Dec 5, 2019

Conversation

srchase
Copy link
Contributor

@srchase srchase commented Dec 3, 2019

migrates and applies AddGlacierApiVersionMiddleware

For now, this hard-codes the api version. This will need to be updated with a way to dynamically pull in the version for the service.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@srchase srchase added the smithy-codegen Changes regarding supporting smithy model. Will be merged to smithy-codegen branch label Dec 3, 2019
@srchase srchase requested a review from AllanZhengYP December 3, 2019 16:34
@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@codecov-io
Copy link

codecov-io commented Dec 3, 2019 •
edited
Loading

Codecov Report

Merging #485 into smithy-codegen will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           smithy-codegen     #485   +/-   ##
===============================================
  Coverage           94.54%   94.54%           
===============================================
  Files                  68       68           
  Lines                1284     1284           
  Branches              256      256           
===============================================
  Hits                 1214     1214           
  Misses                 70       70

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 935ab10...8766e3e. Read the comment docs.

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@srchase srchase requested a review from mtdowling December 4, 2019 23:12
@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AllanZhengYP
AllanZhengYP reviewed Dec 5, 2019
View reviewed changes
packages/middleware-sdk-glacier/src/add-glacier-api-version.ts
): Promise<BuildHandlerOutput<Output>> => {
let request = args.request;
if (HttpRequest.isInstance(request)) {
request.headers["x-amz-glacier-version"] = "2012-06-01";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably need to change after #490 lands

AllanZhengYP
AllanZhengYP reviewed Dec 5, 2019
View reviewed changes
...t-codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/AddBuiltinPlugins.java Outdated
.servicePredicate((m, s) -> testServiceId(s, "S3"))
.build(),
RuntimeClientPlugin.builder()
.withConventions("@aws-sdk/middleware-sdk-glacier", "^0.1.0-preview.7",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing: Can you add these middleware to AwsDependency class, this way we can easier maintain the dependencies

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in 8766e3e

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@srchase srchase merged commit 5f420b5 into aws:smithy-codegen Dec 5, 2019
@srchase srchase deleted the glacier-migration branch December 5, 2019 21:14
@lock
Copy link

lock bot commented Dec 12, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AllanZhengYP AllanZhengYP AllanZhengYP approved these changes

@mtdowling mtdowling Awaiting requested review from mtdowling

Assignees
No one assigned
Labels
smithy-codegen Changes regarding supporting smithy model. Will be merged to smithy-codegen branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@srchase @aws-sdk-js-automation @codecov-io @mtdowling @AllanZhengYP