Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scripts): use since origin/main for ci #4101

Merged
merged 1 commit into from
Oct 26, 2022

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Oct 26, 2022

Issue

Follow-up to #4085

Description

Run CI scripts since origin/main and not main

Testing

Issue was observed while verifying CI run of #4099

The output when main is used:

[Container] 2022/10/26 17:21:12 Running command yarn build:ci
yarn run v1.22.19
$ lerna run build --since main --include-dependencies
lerna notice cli v5.5.2
lerna info ci enabled
lerna notice filter changed since "main"
lerna notice filter including dependencies
lerna info Looking for changed packages since main
lerna info Executing command in 434 packages: "yarn run build"

...

[Container] 2022/10/26 17:26:45 Running command yarn test:ci
yarn run v1.22.19
$ lerna run test --since main --exclude-dependents
lerna notice cli v5.5.2
lerna info ci enabled
lerna notice filter changed since "main"
lerna notice filter excluding dependents
lerna info Looking for changed packages since main
lerna info Executing command in 7 packages: "yarn run test"

The output when origin/main is used:

[Container] 2022/10/26 17:42:14 Running command yarn lerna run build --since origin/main --include-dependencies
yarn run v1.22.19
$ /codebuild/output/src702291909/src/github.com/aws/aws-sdk-js-v3/node_modules/.bin/lerna run build --since origin/main --include-dependencies
lerna notice cli v5.5.2
lerna info ci enabled
lerna notice filter changed since "origin/main"
lerna notice filter including dependencies
lerna info Looking for changed packages since origin/main
lerna success run No packages found with the lifecycle script 'build'

...

[Container] 2022/10/26 17:42:20 Running command yarn lerna run test --since origin/main --exclude-dependents
yarn run v1.22.19
$ /codebuild/output/src702291909/src/github.com/aws/aws-sdk-js-v3/node_modules/.bin/lerna run test --since origin/main --exclude-dependents
lerna notice cli v5.5.2
lerna info ci enabled
lerna notice filter changed since "origin/main"
lerna notice filter excluding dependents
lerna info Looking for changed packages since origin/main
lerna success run No packages found with the lifecycle script 'test'
$ git checkout -b test-build-since-origin-main

# Commit from https://github.com/aws/aws-sdk-js-v3/pull/3833 which only updates util-dynamodb
$ git cherry-pick 334fa3dbc6ec38359dc0e4ca93ba1c5b266ecf06

$ git clean -dfx && yarn && yarn build:crypto-dependencies

$ yarn lerna run build
...
lerna notice cli v5.5.2
lerna info Executing command in 436 packages: "yarn run build"
...

$ yarn lerna run build --since origin/main --include-dependencies
...
lerna notice cli v5.5.2
lerna notice filter changed since "main"
lerna notice filter including dependencies
lerna info Looking for changed packages since main
lerna info Executing command in 61 packages: "yarn run build"
...

$ yarn lerna run test --since origin/main --exclude-dependents
...
lerna notice cli v5.5.2
lerna notice filter changed since "main"
lerna notice filter excluding dependents
lerna info Looking for changed packages since main
lerna info Executing command in 1 package: "yarn run test"
lerna info run Ran npm script 'test' in '@aws-sdk/util-dynamodb' in 5.5s:
...

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr merged commit 1335bfb into aws:main Oct 26, 2022
@trivikr trivikr deleted the use-origin-main-ci-scripts branch October 26, 2022 21:31
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants