Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update eventStreamPayloadHandler to also get prior signature from query string #4100

Merged
merged 1 commit into from
Oct 26, 2022

Conversation

thaddmt
Copy link
Contributor

@thaddmt thaddmt commented Oct 26, 2022

Issue

Issue number, if available, prefixed with "#"

Description

  • Update eventStream-handler-node to also get priorSignature from query string
  • This fixes frame signing issues when signature is in query string

Testing

  • Unit tested, tested locally on private branch with new streaming client

Additional context

Add any other context about the PR here.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@thaddmt thaddmt requested a review from a team as a code owner October 26, 2022 17:37
@kuhe kuhe merged commit d6d9e10 into aws:main Oct 26, 2022
@thaddmt thaddmt deleted the update-eventstream-handler branch October 26, 2022 21:36
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants