Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(codegen): aws-query protocol, distinguish explicit empty list #4003

Merged
merged 2 commits into from
Nov 1, 2022

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Sep 29, 2022

previous

RollbackConfiguration: {
  RollbackTriggers: []
}
->
// (no serialization of this empty list)

proposed

RollbackConfiguration: {
  RollbackTriggers: []
}
->
"RollbackConfiguration.RollbackTriggers": []

@kuhe kuhe requested a review from a team as a code owner September 29, 2022 21:37
@kuhe kuhe force-pushed the fix/aws-query-empty-list branch 3 times, most recently from 71c58be to d7a9655 Compare September 30, 2022 15:59
@kuhe
Copy link
Contributor Author

kuhe commented Sep 30, 2022

this change is failing a protocol test, consulting internally to reconcile

@kuhe kuhe self-assigned this Oct 4, 2022
@kuhe kuhe force-pushed the fix/aws-query-empty-list branch from d7a9655 to 01f8ba8 Compare November 1, 2022 16:22
@kuhe
Copy link
Contributor Author

kuhe commented Nov 1, 2022

the protocol test seems to have been updated, re-running checks on this PR and updated rebase

@kuhe kuhe merged commit 8e10769 into aws:main Nov 1, 2022
@kuhe kuhe deleted the fix/aws-query-empty-list branch November 1, 2022 20:33
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

client-cloudformation - Unable to remove Rollback Triggers
2 participants