Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(credential-provider-sso): readme fixes, clarification #2488

Merged
merged 1 commit into from
Jun 17, 2021

Conversation

allenluce
Copy link
Contributor

Issue

N/A

Description

Clarifies the SSO provider documentation, removes ambiguity, fixes typos and aligns tenses.

Testing

N/A, documentation change only

@alexforsyth alexforsyth changed the title docs(credential-provider-sso) English fixes, clarification. docs(credential-provider-sso): readme fixes, clarification Jun 17, 2021
Copy link
Contributor

@AllanZhengYP AllanZhengYP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix! 🚢

@alexforsyth alexforsyth changed the title docs(credential-provider-sso): readme fixes, clarification package(credential-provider-sso): readme fixes, clarification Jun 17, 2021
@alexforsyth
Copy link
Contributor

@allenluce thanks so much for the PR! Even though its just doc updates, I'll let CI pass and then merge it.

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@ff9df37). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 531af40 differs from pull request most recent head 7a53e0b. Consider uploading reports for the commit 7a53e0b to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2488   +/-   ##
=======================================
  Coverage        ?   59.54%           
=======================================
  Files           ?      493           
  Lines           ?    26357           
  Branches        ?     6261           
=======================================
  Hits            ?    15695           
  Misses          ?    10662           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff9df37...7a53e0b. Read the comment docs.

@allenluce
Copy link
Contributor Author

Sound good! Looks like I forgot a colon in the commit message. I've fixed that and moved the commit to the current top of the main branch.

@alexforsyth alexforsyth changed the title package(credential-provider-sso): readme fixes, clarification docs(credential-provider-sso): readme fixes, clarification Jun 17, 2021
@alexforsyth alexforsyth merged commit 0f6548e into aws:main Jun 17, 2021
@github-actions
Copy link

github-actions bot commented Jul 2, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants