Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KMS Clients #211

Merged
merged 1 commit into from
Mar 27, 2019
Merged

KMS Clients #211

merged 1 commit into from
Mar 27, 2019

Conversation

seebees
Copy link
Contributor

@seebees seebees commented Mar 22, 2019

Issue #, if available:

Description of changes:

Generate KMS service client

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@AllanZhengYP AllanZhengYP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update both package's version to 0.1.0-preview.1? You can re-generate them by supplying --version 0.1.0-preview.1 argument when generating the packages.

@seebees seebees force-pushed the add-kms-clients branch 2 times, most recently from c1e95c1 to b910f36 Compare March 26, 2019 23:05
commands:

node ./packages/package-generator/build/cli.js client --model models/kms/2014-11-01/service-2.json --smoke models/kms/2014-11-01/smoke.json --version 0.1.0-preview.1 --runtime browser

node ./packages/package-generator/build/cli.js client --model models/kms/2014-11-01/service-2.json --smoke models/kms/2014-11-01/smoke.json --version 0.1.0-preview.1 --runtime node
@AllanZhengYP AllanZhengYP merged commit 46d6dd6 into aws:master Mar 27, 2019
@lock
Copy link

lock bot commented May 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators May 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants