Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade uuid to > 9 #3964

Closed
1 of 2 tasks
spence-novata opened this issue Sep 16, 2022 · 7 comments
Closed
1 of 2 tasks

Upgrade uuid to > 9 #3964

spence-novata opened this issue Sep 16, 2022 · 7 comments
Labels
feature-request New feature or enhancement. May require GitHub community feedback. p2 This is a standard priority issue queued This issues is on the AWS team's backlog

Comments

@spence-novata
Copy link

Describe the feature

uuid v9 brings changes to exports allowing it to work with latest versions of Jest without a moduleNameMapper workaround

See uuidjs/uuid#451

Use Case

I'd like to update to jest 29 without hacks

Proposed Solution

Update to UUID v9

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

SDK version used

3.171.0

Environment details (OS name and version, etc.)

macos 12.5

@spence-novata spence-novata added feature-request New feature or enhancement. May require GitHub community feedback. needs-triage This issue or PR still needs to be triaged. labels Sep 16, 2022
@ajredniwja ajredniwja added p2 This is a standard priority issue and removed needs-triage This issue or PR still needs to be triaged. labels Sep 26, 2022
@Fouzyyyy
Copy link

Hello here 👋

Is this being worked on? Or should someone else take it?

@Fouzyyyy
Copy link

Hello @ajredniwja @spence-novata

Is there any plan to move forward with this issue?

@yoyoonarock
Copy link
Contributor

Hey there! Just wanted to bump this and ask if there are any plans to upgrade to uuid v9.0.0 - we're facing a similar issue and don't want to have to implement a moduleNameMapper or custom resolver.

Additional related threads:
microsoft/accessibility-insights-web#5421 (comment)
uuidjs/uuid#616

@diogotorres97
Copy link

bump on this one 🙏

mxro added a commit to mxro/maxrohde-web that referenced this issue Feb 10, 2024
@RanVaknin RanVaknin added the queued This issues is on the AWS team's backlog label Feb 14, 2024
@RanVaknin
Copy link
Contributor

Approved @yoyoonarock 's PR.

@mxro
Copy link

mxro commented Feb 24, 2024

Note while this upgrades uuid in the @aws-sdk/ packages, I still get an error since [email protected] is a dependency in @smithy/[email protected], which is used by many of the SDK packages.

SyntaxError: Unexpected token 'export'

      38 |   });
      39 | };
    > 40 |
         | ^
      41 | export interface ConnectTableParams {
      42 |   deploymentName?: string;
      43 |   documentClient?: DynamoDBDocumentClient;

      at Runtime.createScriptFromCode (../../.yarn/cache/jest-runtime-npm-29.5.0-e692162e2b-7af27bd9d5.zip/node_modules/jest-runtime/build/index.js:1495:14)
      at Object.<anonymous> (../../.yarn/cache/@smithy-middleware-retry-npm-2.1.1-82a581ceb3-a4bc59d2ff.zip/node_modules/@smithy/middleware-retry/dist-cjs/index.js:51:19)

This is with client SDK versions 3.521.0

Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request New feature or enhancement. May require GitHub community feedback. p2 This is a standard priority issue queued This issues is on the AWS team's backlog
Projects
None yet
Development

No branches or pull requests

7 participants