test(packages): await promise assertions, cleanup test logging (#6839)

aws · Jan 22, 2025 · e504341 · e504341
1 parent 84d6c18
commit e504341
Show file tree

Hide file tree

Showing 9 changed files with 14 additions and 13 deletions.
diff --git a/clients/client-s3/test/unit/S3.spec.ts b/clients/client-s3/test/unit/S3.spec.ts
@@ -304,6 +304,7 @@ describe("signing", () => {
     return await client.putObject({
       Bucket: "bucket",
       Key: "some file.txt",
+      Body: "abcd",
     });
   });
 });
diff --git a/lib/lib-storage/src/Upload.spec.ts b/lib/lib-storage/src/Upload.spec.ts
@@ -788,7 +788,7 @@ describe(Upload.name, () => {
     });
 
     await upload.done();
-    expect(() => upload.done()).rejects.toEqual(
+    await expect(() => upload.done()).rejects.toEqual(
       new Error("@aws-sdk/lib-storage: this instance of Upload has already executed .done(). Create a new instance.")
     );
   });

diff --git a/packages/dsql-signer/src/runtimeConfig.spec.ts b/packages/dsql-signer/src/runtimeConfig.spec.ts
@@ -13,7 +13,7 @@ describe("getRuntimeConfig", () => {
       hostname: "test.example.com",
     };
     const { credentials, region } = getRuntimeConfig(minimalParams);
-    expect(credentials).rejects.toEqual("Credential is missing");
-    expect(region).rejects.toEqual("Region is missing");
+    await expect(credentials).rejects.toEqual("Credential is missing");
+    await expect(region).rejects.toEqual("Region is missing");
   });
 });
diff --git a/packages/eventstream-handler-node/src/EventStreamPayloadHandler.spec.ts b/packages/eventstream-handler-node/src/EventStreamPayloadHandler.spec.ts
@@ -36,13 +36,13 @@ describe(EventStreamPayloadHandler.name, () => {
     vi.clearAllMocks();
   });
 
-  it("should throw if request payload is not a stream", () => {
+  it("should throw if request payload is not a stream", async () => {
     const handler = new EventStreamPayloadHandler({
       messageSigner: () => Promise.resolve(mockMessageSigner),
       utf8Decoder: mockUtf8Decoder,
       utf8Encoder: mockUtf8encoder,
     });
-    expect(
+    await expect(
       handler.handle(mockNextHandler, {
         request: { body: "body" } as HttpRequest,
         input: {},

diff --git a/packages/middleware-endpoint-discovery/src/resolveEndpointDiscoveryConfig.spec.ts b/packages/middleware-endpoint-discovery/src/resolveEndpointDiscoveryConfig.spec.ts
@@ -42,15 +42,15 @@ describe(resolveEndpointDiscoveryConfig.name, () => {
   });
 
   describe("endpointDiscoveryEnabled", () => {
-    it.each<boolean>([false, true])(`sets to value passed in the config: %s`, (endpointDiscoveryEnabled) => {
+    it.each<boolean>([false, true])(`sets to value passed in the config: %s`, async (endpointDiscoveryEnabled) => {
       const resolvedConfig = resolveEndpointDiscoveryConfig(
         {
           ...mockInput,
           endpointDiscoveryEnabled,
         },
         { endpointDiscoveryCommandCtor }
       );
-      expect(resolvedConfig.endpointDiscoveryEnabled()).resolves.toBe(endpointDiscoveryEnabled);
+      await expect(resolvedConfig.endpointDiscoveryEnabled()).resolves.toBe(endpointDiscoveryEnabled);
       expect(mockInput.endpointDiscoveryEnabledProvider).not.toHaveBeenCalled();
       expect(resolvedConfig.isClientEndpointDiscoveryEnabled).toStrictEqual(true);
     });

diff --git a/packages/middleware-sdk-s3/src/check-content-length-header.spec.ts b/packages/middleware-sdk-s3/src/check-content-length-header.spec.ts
@@ -9,7 +9,7 @@ describe("checkContentLengthHeaderMiddleware", () => {
   let spy: any;
 
   beforeEach(() => {
-    spy = vi.spyOn(console, "warn");
+    spy = vi.spyOn(console, "warn").mockImplementation(() => {});
   });
 
   afterEach(() => {

diff --git a/packages/middleware-token/src/normalizeTokenProvider.spec.ts b/packages/middleware-token/src/normalizeTokenProvider.spec.ts
@@ -32,7 +32,7 @@ describe(normalizeTokenProvider.name, () => {
     it("returns memoized function", async () => {
       const normalizedTokenProvider = normalizeTokenProvider(mockInputToken);
       expect(normalizedTokenProvider).toEqual(mockMemoizeFn);
-      expect(mockMemoizeFn()).resolves.toEqual(mockToken);
+      await expect(mockMemoizeFn()).resolves.toEqual(mockToken);
     });
 
     describe("memoize isExpired", () => {

diff --git a/packages/middleware-websocket/src/EventStreamPayloadHandler.spec.ts b/packages/middleware-websocket/src/EventStreamPayloadHandler.spec.ts
@@ -29,13 +29,13 @@ describe(EventStreamPayloadHandler.name, () => {
     vi.clearAllMocks();
   });
 
-  it("should throw if request payload is not a stream", () => {
+  it("should throw if request payload is not a stream", async () => {
     const handler = new EventStreamPayloadHandler({
       messageSigner: () => Promise.resolve(mockSigner),
       utf8Decoder: mockUtf8Decoder,
       utf8Encoder: mockUtf8encoder,
     });
-    expect(
+    await expect(
       handler.handle(mockNextHandler, {
         request: { body: "body" } as HttpRequest,
         input: {},

diff --git a/packages/rds-signer/src/runtimeConfig.spec.ts b/packages/rds-signer/src/runtimeConfig.spec.ts
@@ -15,7 +15,7 @@ describe("getRuntimeConfig", () => {
       port: 5432,
     };
     const { credentials, region } = getRuntimeConfig(minimalParams);
-    expect(credentials).rejects.toEqual("Credential is missing");
-    expect(region).rejects.toEqual("Region is missing");
+    await expect(credentials).rejects.toEqual("Credential is missing");
+    await expect(region).rejects.toEqual("Region is missing");
   });
 });