Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: switch to alpha releases of @aws-sdk packages #19

Merged
merged 9 commits into from
Jan 11, 2020
Merged

chore: switch to alpha releases of @aws-sdk packages #19

merged 9 commits into from
Jan 11, 2020

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jan 8, 2020

Issue #, if available:
Refs: #18

Description of changes:

  • switch to alpha releases of @AWS-SDK packages
  • Will mark for review once alpha packages are released

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@trivikr trivikr marked this pull request as ready for review January 8, 2020 03:53
@trivikr
Copy link
Member Author

trivikr commented Jan 8, 2020

This PR is ready to review

But I would like to set up TravisCI on this project first before merging this PR #21

@mattsb42-aws
Copy link
Member

.github/workflows/ci-unit-tests.yaml Expected — Waiting for status to be reported

Assuming this uses the same underlying thing as the badges, if a workflow has a name defined, it needs to be referenced by the name, not the filepath.

https://help.github.com/en/actions/automating-your-workflow-with-github-actions/configuring-a-workflow#adding-a-workflow-status-badge-to-your-repository

@trivikr
Copy link
Member Author

trivikr commented Jan 11, 2020

@mattsb42-aws Any action item for me on this?

@mattsb42-aws
Copy link
Member

@mattsb42-aws Any action item for me on this?

No; that was meant as a message to @seebees. We just needed to change how the branch protection rules were set.

@seebees seebees merged commit 5ecf851 into aws:master Jan 11, 2020
@trivikr trivikr deleted the switch-to-js-sdk-alpha branch January 11, 2020 01:54
@trivikr
Copy link
Member Author

trivikr commented Jan 14, 2020

@seebees Can you release alpha (or preview) versions of @aws-crypto packages with these dependencies?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants