Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use v3 client name when input code does not use local name #594

Merged
merged 18 commits into from
Oct 16, 2023

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Oct 3, 2023

Issue

Fixes: #593

Description

Uses v3 client name when creating clients with global name

Testing

CI


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@changeset-bot
Copy link

changeset-bot bot commented Oct 3, 2023

🦋 Changeset detected

Latest commit: 54f33d2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
aws-sdk-js-codemod Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@trivikr

This comment was marked as outdated.

@trivikr trivikr closed this Oct 3, 2023
@trivikr trivikr deleted the global-import-v3-name branch October 3, 2023 17:13
@trivikr trivikr restored the global-import-v3-name branch October 15, 2023 23:06
@trivikr trivikr reopened this Oct 15, 2023
@trivikr trivikr closed this Oct 15, 2023
@trivikr trivikr deleted the global-import-v3-name branch October 15, 2023 23:16
@trivikr trivikr restored the global-import-v3-name branch October 15, 2023 23:34
@trivikr trivikr reopened this Oct 15, 2023
@trivikr trivikr force-pushed the global-import-v3-name branch from c896dd4 to 36f621d Compare October 15, 2023 23:35
@trivikr trivikr changed the title Use v3 client name when creating clients with global name Use v3 client name when input code does not use local name Oct 16, 2023
@trivikr trivikr marked this pull request as ready for review October 16, 2023 03:15
@trivikr trivikr requested a review from a team as a code owner October 16, 2023 03:15
@trivikr trivikr merged commit c1c8016 into main Oct 16, 2023
@trivikr trivikr deleted the global-import-v3-name branch October 16, 2023 03:16
@github-actions
Copy link
Contributor

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Use v3 client name when transforming clients created with global import
1 participant