Remove non-null assertions using the ! postfix operator (#898)

aws · Jul 12, 2024 · bf76ad1 · bf76ad1
1 parent a301bf9
commit bf76ad1
Show file tree

Hide file tree

Showing 7 changed files with 11 additions and 6 deletions.
diff --git a/.changeset/quick-chefs-fix.md b/.changeset/quick-chefs-fix.md
@@ -0,0 +1,5 @@
+---
+"aws-sdk-js-codemod": patch
+---
+
+Remove non-null assertions using the `!` postfix operator
diff --git a/biome.json b/biome.json
@@ -22,7 +22,6 @@
       },
       "style": {
         "noNamespace": "error",
-        "noNonNullAssertion": "off",
         "noUnusedTemplateLiteral": "off",
         "useConsistentArrayType": {
           "level": "error",

diff --git a/src/transforms/v2-to-v3/modules/getRequireDeclaratorsWithProperty.ts b/src/transforms/v2-to-v3/modules/getRequireDeclaratorsWithProperty.ts
@@ -18,7 +18,7 @@ export const getRequireDeclaratorsWithProperty = (
 
     if (declaratorId.type === "Identifier") {
       const declaratorIdName = declaratorId.name;
-      if (declaratorInit!.type === "MemberExpression") {
+      if (declaratorInit?.type === "MemberExpression") {
         const importedName = (declaratorInit.property as Identifier).name;
         if (localName === declaratorIdName && identifierName === importedName) {
           return true;

diff --git a/src/transforms/v2-to-v3/modules/importEqualsModule/getDefaultName.ts b/src/transforms/v2-to-v3/modules/importEqualsModule/getDefaultName.ts
@@ -1,2 +1,3 @@
 export const getDefaultName = (packageName: string) =>
+  // biome-ignore lint/style/noNonNullAssertion: This is a valid assertion
   ["AWS", ...packageName.split("/").pop()!.split("-")].join("_");
diff --git a/src/transforms/v2-to-v3/modules/importModule/getImportSpecifiers.ts b/src/transforms/v2-to-v3/modules/importModule/getImportSpecifiers.ts
@@ -17,7 +17,7 @@ export const getImportSpecifiers = (
           const importedName = specifier.imported.name;
           importSpecifiers.add({
             importedName,
-            localName: specifier.local!.name || importedName,
+            localName: specifier.local?.name || importedName,
           });
           break;
         }

diff --git a/src/transforms/v2-to-v3/modules/requireModule/getImportSpecifiers.ts b/src/transforms/v2-to-v3/modules/requireModule/getImportSpecifiers.ts
@@ -37,7 +37,7 @@ export const getImportSpecifiers = (
 
     if (declaratorId.type === "Identifier") {
       const declaratorIdName = declaratorId.name;
-      if (declaratorInit!.type === "MemberExpression") {
+      if (declaratorInit?.type === "MemberExpression") {
         importSpecifiers.add({
           importedName: (declaratorInit.property as Identifier).name,
           localName: declaratorIdName,
@@ -48,7 +48,7 @@ export const getImportSpecifiers = (
     }
 
     if (declaratorId.type === "ObjectPattern") {
-      if (declaratorInit!.type !== "CallExpression") {
+      if (declaratorInit?.type !== "CallExpression") {
         continue;
       }
       const properties = declaratorId.properties as (Property | ObjectProperty)[];

diff --git a/src/transforms/v2-to-v3/ts-type/getClientTypeNames.ts b/src/transforms/v2-to-v3/ts-type/getClientTypeNames.ts
@@ -58,7 +58,7 @@ export const getClientTypeNames = (
   clientTypeNames.push(
     ...getImportSpecifiers(j, source, getClientDeepImportPath(v2ClientName))
       .filter((importSpecifier) => importSpecifier.importedName)
-      .map((importSpecifier) => (importSpecifier as ImportSpecifierType).localName!)
+      .map((importSpecifier) => (importSpecifier as ImportSpecifierType).localName)
   );
 
   return [...new Set(clientTypeNames)];