service/s3/s3manager: Add DownloadStrategy for buffering downloaded parts #2823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skmcgrail
added
the
needs-review
skmcgrail
force-pushed
the
s3manager/downloader
branch
15 times, most recently
from
9049c8b to
704b53e
Compare
jasdel
suggested changes
Sep 18, 2019
awstesting/integration/performance/s3DownloadManager/endless_reader.go
Outdated
Show resolved
Hide resolved
awstesting/integration/performance/s3DownloadManager/discard.go
Outdated
Show resolved
Hide resolved
skmcgrail
force-pushed
the
s3manager/downloader
branch
3 times, most recently
from
60065de to
97b588b
Compare
skmcgrail
force-pushed
the
s3manager/downloader
branch
from
97b588b to
0bd9654
Compare
jasdel
suggested changes
Sep 20, 2019
awstesting/integration/performance/s3DownloadManager/main_test.go
Outdated
Show resolved
Hide resolved
skmcgrail
force-pushed
the
s3manager/downloader
branch
from
0bd9654 to
d772a77
Compare
jasdel
suggested changes
Sep 24, 2019
skmcgrail
force-pushed
the
s3manager/downloader
branch
from
d772a77 to
82ef9a5
Compare
|
Fixed improper import ordering for the sdkio package, and updated changelog. |
jasdel
reviewed
Sep 25, 2019
skmcgrail
force-pushed
the
s3manager/downloader
branch
from
82ef9a5 to
508fe8f
Compare
skmcgrail
force-pushed
the
s3manager/downloader
branch
from
508fe8f to
14601e8
Compare
jasdel
approved these changes
Sep 25, 2019
skmcgrail
removed
the
needs-review
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a buffering strategy for the download S3 manager. This is similar to the upload strategy being reviewed as part of #2792