-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
codegen: Remove protocol test skipping for supported features. #1630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created #1631 tracking endpoint prefix and host label protocol tests the SDK is skipping |
Unit test failing because presigned URL behavior needs to deviate from regular API behavior and no include or remove the auto set content-type for operations with streaming input. |
This change in behavior I believe is unexpected.
|
27ed14c
to
bb590e1
Compare
Updates the SDK's code generation of protocol test to no longer skip tests for features that are supported by the SDK.
bb590e1
to
e5de23d
Compare
skmcgrail
reviewed
Jun 28, 2022
...en/src/main/java/software/amazon/smithy/aws/go/codegen/AwsHttpPresignURLClientGenerator.java
Outdated
Show resolved
Hide resolved
skmcgrail
approved these changes
Jun 28, 2022
jasdel
added a commit
to aws/smithy-go
that referenced
this pull request
Jun 28, 2022
Updates the SDK's codegen for REST HTTP request payload to always include content-type header for operations with streaming request payloads. Prior the content-type header would only be added if the streaming request io.Reader was not nil. Also adds a helper utility for setting if the content-type was automatically assigned by the operation serializer or not. Used by behavior that needs to know if an explicit or default value was provided for the content-type header. Replaces: #360 Used by: aws/aws-sdk-go-v2#1630
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the SDK's code generation of protocol test to no longer skip
tests for features that are supported by the SDK.
Regenerates SDK API clients for aws/smithy-go#360 and previously skipped protocol tests