Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1486: dynamo/attributevalue allow json tag encoding/decoding #1520

Closed
wants to merge 2 commits into from

Conversation

moogacs
Copy link

@moogacs moogacs commented Dec 3, 2021

#1486 reads json tags on marshalling structs

@jasdel
Copy link
Contributor

jasdel commented Dec 3, 2021

Thanks for taking the time to create this PR @moogacs I updated #1486 with information how to use alternative tags with the attributevalue package's (un)marshalers.

In addition, adding support for json struct tag name by default could be a breaking change for some users where serialization of structure field names would change, and no longer be compatible with their data stored in their table.

Lets use #1486 and #1494 for discussion of this issue.

@jasdel jasdel closed this Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants