Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

smithy/tracing/TraceSpan.h conflicts with wingdi.h #2590

Closed
ShimYama opened this issue Jul 21, 2023 · 3 comments
Closed

smithy/tracing/TraceSpan.h conflicts with wingdi.h #2590

ShimYama opened this issue Jul 21, 2023 · 3 comments
Assignees
@yasminetalby
Labels
bug This issue is a bug. p2 This is a standard priority issue pending-release This issue will be fixed by an approved PR that hasn't been released yet.

Comments

@ShimYama
Copy link
Contributor

Describe the bug

The enum value smithy::components::tracing::TraceSpanStatus::ERROR conflicts with ERROR macro in wingdi.h

Expected Behavior

No conflict occurs.

Current Behavior

C2059, C3805 error occurs.

Reproduction Steps

Make a project with wingdi.h header file and build it, the you will find the error.

Possible Solution

Adding these lines in TraceSpan.h may help but I'm not sure there's any subeffects.

#ifdef _WIN32
#ifdef ERROR
#undef ERROR
#endif
#endif

Additional Information/Context

No response

AWS CPP SDK version used

1.11.123

Compiler and Version used

Visual Studio 2015 Community / Build Engine version 14.0.25420.1

Operating System and version

Windows 10 Pro 22H2
@ShimYama ShimYama added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Jul 21, 2023
@yasminetalby yasminetalby self-assigned this Jul 21, 2023
@yasminetalby yasminetalby added p2 This is a standard priority issue and removed needs-triage This issue or PR still needs to be triaged. labels Jul 21, 2023
@yasminetalby
Copy link
Contributor

Hello @ShimYama ,

Thank you very much for your submission and for bringing this up to our attention.
I will submit a fix for this issue and will update you here when it is released.

Best regards,

Yasmine

yasminetalby pushed a commit that referenced this issue Jul 21, 2023
Fix for issue #2590 : Fixes conflicts with ERROR macro in wingdi.h
c957adf
@yasminetalby yasminetalby mentioned this issue Jul 21, 2023
Merged
11 tasks
@yasminetalby yasminetalby added the pending-release This issue will be fixed by an approved PR that hasn't been released yet. label Jul 21, 2023
yasminetalby added a commit that referenced this issue Aug 17, 2023
@yasminetalby
Fix for issue #2590 : Fixes conflicts with ERROR macro in wingdi.h (#…
314c1d7 
…2591)

* Fix for issue #2590 : Fixes conflicts with ERROR macro in wingdi.h

* fix 2590

---------

Co-authored-by: Talby <[email protected]>
@yasminetalby
Copy link
Contributor

This should be fixed in 1.11.152!

Thank you very much for reporting this issue.

Best,

Yasmine

@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yasminetalby yasminetalby

Labels
bug This issue is a bug. p2 This is a standard priority issue pending-release This issue will be fixed by an approved PR that hasn't been released yet.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ShimYama @yasminetalby