Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): bump mypy from 1.11.2 to 1.13.0 in /requirements #7632

Merged
merged 4 commits into from
Nov 15, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix typing issues
  • Loading branch information
mndeveci committed Nov 15, 2024
commit 23e126f0d3a2ed1110c4d9e372bae279fa28d0ed
Original file line number Diff line number Diff line change
Expand Up @@ -357,7 +357,7 @@ def _link_using_linking_fields(self, cfn_resource: Dict) -> None:
child_resources_linking_attributes_logical_id_mapping,
)

dest_resources = [
dest_resources: List[ReferenceType] = [
(
LogicalIdReference(
value=child_resources_linking_attributes_logical_id_mapping[value][0],
Expand Down
2 changes: 1 addition & 1 deletion samcli/lib/build/workflow_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ def get_workflow_config(
) from ex


def supports_specified_workflow(specified_workflow: str) -> bool:
def supports_specified_workflow(specified_workflow: Optional[str]) -> bool:
"""
Given a specified workflow, returns whether it is supported in container builds,
can be used to overwrite runtime and get docker image or not
Expand Down
4 changes: 2 additions & 2 deletions samcli/lib/sync/flows/layer_sync_flow.py
Original file line number Diff line number Diff line change
Expand Up @@ -409,8 +409,8 @@ def sync(self) -> None:
return

# Check function uses layer
old_layer_arn = [layer_arn for layer_arn in layer_arns if layer_arn.startswith(self._layer_arn)]
old_layer_arn = old_layer_arn[0] if len(old_layer_arn) == 1 else None
old_layer_arns = [layer_arn for layer_arn in layer_arns if layer_arn.startswith(self._layer_arn)]
old_layer_arn = old_layer_arns[0] if len(old_layer_arns) == 1 else None
if not old_layer_arn:
LOG.warning(
"%sLambda Function (%s) does not have layer (%s).%s",
Expand Down
Loading