fix: Update to OpenSSL 3.3.1 to avoid the issue with subprocess.check… #7566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
pr/external
stage/needs-triage
dkphm
added
pr/internal
and removed
pr/external
stage/needs-triage
mndeveci
approved these changes
Oct 18, 2024
hnnasit
reviewed
Oct 18, 2024
| @@ -16,7 +16,7 @@ if [ "$python_version" = "" ]; then | |||
| fi | |||
|
|
|||
| if [ "$openssl_version" = "" ]; then | |||
| openssl_version="3.0.15"; | |||
| openssl_version="3.3.1"; | |||
There was a problem hiding this comment.
Should we also make sure there's no CVE's detected in the new version being used? We can also monitor that once this PR is merged.
There was a problem hiding this comment.
Good point, it seems like there is no report about this version yet (only some fixes). https://openssl-library.org/news/vulnerabilities/index.html
I agree that we should monitor pipeline afterwards
hnnasit
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…_output
Which issue(s) does this change fix?
#7408
Why is this change necessary?
To address the issue of
git clonereturn status 128 withsam initrunning on some Linux distributions.How does it address the issue?
The issue happened because older version of OpenSSL 3 interfered with Python's subprocess PIPE output, causing
git cloneexited with an error.What side effects does this change have?
Newer version of OpenSSL 3 might cause other issues.
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.