Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix ruby version to match with AppVeyor's new Linux image #7357

Merged
merged 5 commits into from
Aug 14, 2024

Conversation

dkphm
Copy link
Contributor

@dkphm dkphm commented Aug 14, 2024

Which issue(s) does this change fix?

N/A

Why is this change necessary?

Canary tests failed due to wrong ruby versions

How does it address the issue?

Fix ruby versions accordingly

What side effects does this change have?

N/A

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • [X ] make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dkphm dkphm requested a review from a team as a code owner August 14, 2024 16:23
@dkphm dkphm requested review from hawflau and sidhujus August 14, 2024 16:23
@github-actions github-actions bot added pr/external stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. labels Aug 14, 2024
@dkphm dkphm added this pull request to the merge queue Aug 14, 2024
Merged via the queue into aws:develop with commit 7b5cf94 Aug 14, 2024
55 checks passed
@dkphm dkphm deleted the fix-ruby32 branch August 14, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/internal stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants