Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update the json schema type for tags option for deploy and sync commands #7140

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

hnnasit
Copy link
Contributor

@hnnasit hnnasit commented Jun 6, 2024

Which issue(s) does this change fix?

#6851

Why is this change necessary?

The tags option can either be a string or list but the SAM CLI schema specifies the type as List right now.

How does it address the issue?

Makes the type either a string or list for tags

What side effects does this change have?

No side effects

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • [x ] make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hnnasit hnnasit requested a review from a team as a code owner June 6, 2024 17:29
@hnnasit hnnasit requested review from mildaniel and sidhujus June 6, 2024 17:29
@github-actions github-actions bot added area/schema JSON schema file pr/internal labels Jun 6, 2024
@hnnasit hnnasit added this pull request to the merge queue Jun 6, 2024
Merged via the queue into aws:develop with commit 70983c8 Jun 7, 2024
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants