Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: File Observer Inside Container #6845

Merged
merged 9 commits into from
Mar 16, 2024

Conversation

mildaniel
Copy link
Contributor

Which issue(s) does this change fix?

#6688

Why is this change necessary?

When providing --docker-volume-basedir, the Lambda function is correctly spun up by a mapping the host path to the container path. However, the file watcher keeps trying to use the host path which might not exist in inside the container.

How does it address the issue?

Keeps a reference to the container source code path and uses that path in the file observer instead.

What side effects does this change have?

N/A

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mildaniel mildaniel requested a review from a team as a code owner March 15, 2024 20:19
@mildaniel mildaniel requested review from hawflau and bentvelj March 15, 2024 20:19
@mildaniel mildaniel changed the title Fix observer in docker fix: File Observer Inside Container Mar 15, 2024
@mildaniel mildaniel added this pull request to the merge queue Mar 15, 2024
Merged via the queue into aws:develop with commit 2f5d408 Mar 16, 2024
55 checks passed
@mildaniel mildaniel deleted the fix-observer-in-docker branch March 18, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants