Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): Skip SIGTERM tests on Windows #6722

Merged
merged 3 commits into from
Feb 21, 2024

Conversation

mildaniel
Copy link
Contributor

Which issue(s) does this change fix?

N/A

Why is this change necessary?

Integration tests are failing on Windows since the SIGTERM signal isn't terminating the process.

How does it address the issue?

Skip these tests entirely since they're not relevant for Windows.

What side effects does this change have?

N/A

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mildaniel mildaniel changed the title Skip sigterm tests windows fix(test): Skip SIGTERM tests on Windows Feb 21, 2024
@mildaniel mildaniel marked this pull request as ready for review February 21, 2024 00:00
@mildaniel mildaniel requested a review from a team as a code owner February 21, 2024 00:00
@mildaniel mildaniel enabled auto-merge February 21, 2024 00:27
@mildaniel mildaniel added this pull request to the merge queue Feb 21, 2024
Merged via the queue into aws:develop with commit 42ca587 Feb 21, 2024
55 checks passed
@mildaniel mildaniel deleted the skip-sigterm-tests-windows branch February 21, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants