Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Lock for removing decompressed paths #6695

Merged
merged 14 commits into from
Feb 20, 2024

Conversation

jysheng123
Copy link
Contributor

@jysheng123 jysheng123 commented Feb 14, 2024

Which issue(s) does this change fix?

#6663

Why is this change necessary?

When a temporary directories are made and parallel requests are made, it concurrently tries to delete the same temp directory, resulting in errors due to race conditions.

How does it address the issue?

By adding a lock on each instance of the runtime, we are removing the temp directory one at a time, then the next run of the same instance sees that it is already deleted and does not try to remove an nonexistent path

What side effects does this change have?

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jysheng123 jysheng123 marked this pull request as ready for review February 14, 2024 23:15
@jysheng123 jysheng123 requested a review from a team as a code owner February 14, 2024 23:15
@jysheng123 jysheng123 changed the title Lock rm decompressed paths Add a Lock for removing decompressed paths Feb 14, 2024
Copy link
Contributor

@lucashuy lucashuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes

@jysheng123 jysheng123 added this pull request to the merge queue Feb 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 16, 2024
@jysheng123 jysheng123 added this pull request to the merge queue Feb 20, 2024
Merged via the queue into develop with commit 3451d0b Feb 20, 2024
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants