Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lock invocation per function for not having concurrent requests #6622

Merged
merged 5 commits into from
Feb 3, 2024

Conversation

mndeveci
Copy link
Contributor

@mndeveci mndeveci commented Jan 31, 2024

Which issue(s) does this change fix?

#6157

Why is this change necessary?

When running sam local start-api SAM CLI spins up one container per lambda function. Any concurrent request might fail (or have side-effects) due to this limitation.

How does it address the issue?

Create lock per function endpoint and only allow single execution per function.

What side effects does this change have?

N/A

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mndeveci mndeveci marked this pull request as ready for review February 1, 2024 00:40
@mndeveci mndeveci requested a review from a team as a code owner February 1, 2024 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants