Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEMPORARY] Copy project for flaky test to reference and bump timeout #6599

Closed
wants to merge 0 commits into from

Conversation

bentvelj
Copy link
Contributor

Bumping the timeout for a project used by a flaky golang e2e test that occasionally times out on canaries to observe results.

Temporarily changing the test to use this local test project instead of the one on aws-sam-cli-app-templates

Will revert this change after the flaky test timeout is resolved.

Which issue(s) does this change fix?

Why is this change necessary?

Allows us to bump the timeout only for this test without affecting any other tests

How does it address the issue?

Test will run on temporary local project with extended timeout

What side effects does this change have?

N/A

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@bentvelj bentvelj requested a review from a team as a code owner January 23, 2024 23:08
@bentvelj bentvelj requested review from lucashuy, mildaniel and sidhujus and removed request for mildaniel January 23, 2024 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants