Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove version from rest api payload #6532

Merged
merged 5 commits into from
Jan 9, 2024
Merged

Conversation

sidhujus
Copy link
Contributor

@sidhujus sidhujus commented Jan 5, 2024

Which issue(s) does this change fix?

#6442

Why is this change necessary?

Currently the v1 payload is used for both http API's that specify v1 and for REST api's, which is technically wrong since the REST payload does not contain the version field (but is identical in every other aspect that I checked)

How does it address the issue?

adds an extra parameter to the init method that specifies which type of api is being used.

What side effects does this change have?

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sidhujus
Copy link
Contributor Author

sidhujus commented Jan 5, 2024

https://github.com/aws/aws-sam-cli/pull/6532/files#diff-1cea545ee08253b7df8b2edd1e1809613a5e05666c2e7609e89aa036920651f6R372

I couldn't find anything related to where this is used or whether by v1 we are referring to REST apis or v1 HTTP api payloads

@sidhujus sidhujus marked this pull request as ready for review January 5, 2024 22:19
@sidhujus sidhujus requested a review from a team as a code owner January 5, 2024 22:19
@sidhujus sidhujus requested review from lucashuy and hnnasit January 5, 2024 22:19
@sidhujus sidhujus added this pull request to the merge queue Jan 9, 2024
@sidhujus sidhujus removed this pull request from the merge queue due to a manual request Jan 9, 2024
@sidhujus sidhujus added this pull request to the merge queue Jan 9, 2024
Merged via the queue into aws:develop with commit cfa435b Jan 9, 2024
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants