Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check available port for specific/intended interface #6300

Merged
merged 3 commits into from
Nov 21, 2023

Conversation

mndeveci
Copy link
Contributor

Which issue(s) does this change fix?

N/A

When finding available local port for binding AWS Runtime Interface Emulator, we first try to bind a local port to see if it is available. However that call is been made without providing any network interface that we are intended to.

With this change, when we are searching for available port, we are trying to bind a random port to specific host interface that is defined with --container-host-interface parameter of the sam local commands.

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mndeveci mndeveci requested a review from a team as a code owner November 17, 2023 23:56
Copy link
Contributor

@mildaniel mildaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Mehmet, LGTM. Were these changes validated against the canaries?

@mndeveci
Copy link
Contributor Author

Thanks Mehmet, LGTM. Were these changes validated against the canaries?

As discussed offline, I've validated local tests on Linux and will be monitoring canaries tomorrow to see if there are any failures regarding to this change.

@mndeveci mndeveci added this pull request to the merge queue Nov 21, 2023
Merged via the queue into aws:develop with commit 6726731 Nov 21, 2023
@mndeveci mndeveci changed the title fic: check available port for specific/intended interface fix: check available port for specific/intended interface Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants