Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: bump AWS::Serverless::Function runtime nodejs10.x to nodejs18.x #6289

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Nov 17, 2023

Which issue(s) does this change fix?

Refs: #6195

Why is this change necessary?

Lambda nodejs10.x creation was stopped on Jul 30, 2021

How does it address the issue?

Bumps AWS::Serverless::Function runtime nodejs10.x to nodejs18.x

What side effects does this change have?

N/A

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@trivikr trivikr requested a review from a team as a code owner November 17, 2023 03:35
@github-actions github-actions bot added pr/external stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. labels Nov 17, 2023
Copy link
Contributor

@hnnasit hnnasit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these changes!

@mildaniel mildaniel added this pull request to the merge queue Nov 20, 2023
Merged via the queue into aws:develop with commit d5f7ba5 Nov 20, 2023
@trivikr trivikr deleted the lambda-node-10.x branch November 20, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/external stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants