Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: bump AWS::Serverless::Function runtime nodejs12.x to nodejs18.x #6228

Merged
merged 3 commits into from
Nov 16, 2023

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Nov 8, 2023

Which issue(s) does this change fix?

Refs: #6195

Why is this change necessary?

Lambda nodejs12.x creation was stopped on Mar 31, 2023

How does it address the issue?

Bumps AWS::Serverless::Function runtime nodejs12.x to nodejs18.x

What side effects does this change have?

N/A

Mandatory Checklist

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added pr/external stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. labels Nov 8, 2023
@trivikr
Copy link
Member Author

trivikr commented Nov 8, 2023

If any of the zipped Lambda functions uses Lambda Provided JS SDK v2, the Lambda invocations may fail.

Since this tests SAM CLI, and not Lambda The JS SDK team recommends bumping to v3, and deploying the dependency in node_modules.

@trivikr trivikr force-pushed the lambda-node12-to-node18 branch from 91a387d to 6c8fd91 Compare November 8, 2023 20:46
@trivikr trivikr marked this pull request as ready for review November 8, 2023 20:47
@trivikr trivikr requested a review from a team as a code owner November 8, 2023 20:47
@trivikr trivikr requested review from bentvelj and mildaniel November 8, 2023 20:47
@trivikr trivikr force-pushed the lambda-node12-to-node18 branch from 6c8fd91 to b201b81 Compare November 10, 2023 05:40
Copy link
Contributor

@hnnasit hnnasit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @trivikr for your contributions.

@hnnasit hnnasit removed the stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. label Nov 16, 2023
@hnnasit hnnasit enabled auto-merge November 16, 2023 21:38
@hnnasit hnnasit added this pull request to the merge queue Nov 16, 2023
Merged via the queue into aws:develop with commit 1c6175f Nov 16, 2023
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants