Chore: Use the latest stack event timestamp as a marker to get the new deployment events #5852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moelasmar
force-pushed
the
develop_deploy_logs
branch
from
453afc5 to
de1cc49
Compare
moelasmar
changed the title
moelasmar
changed the title
moelasmar
changed the title
lucashuy
approved these changes
Oct 23, 2023
moelasmar
changed the title
moelasmar
changed the title
mndeveci
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add some logs to deploy command to investigate issue # #5109
The problem in that issue is the WSL environment clock is not in sync with the actual time, it was 3 minutes ahead, and so the loop we use to describe the deployment events never ends, as it is not able to find any new events.
I updated the wait_for_execute method that wait for a change set to be executed, to take a time_stamp_marker as an extra parameter to use it to determine the events to be printed. The value of this marker will be the latest stack event if the stack exists, or 0 in case if the stack does not exist.
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.