Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Prompt users to use TFC workaround #5755

Merged
merged 1 commit into from
Aug 12, 2023

Conversation

mildaniel
Copy link
Contributor

Which issue(s) does this change fix?

N/A

Why is this change necessary?

Prompt users to use the Terraform Cloud workaround when they encounter the TFC error.

How does it address the issue?

  1. Fixes the loading dot subprocess loader to store and return data from stderr
  2. Reads the stderr data, checking for the TFC error message and returns an appropriate help message if found.

What side effects does this change have?

N/A

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mildaniel mildaniel requested a review from a team as a code owner August 11, 2023 21:34
@mildaniel mildaniel requested review from hawflau and hnnasit August 11, 2023 21:34
@mildaniel mildaniel added this pull request to the merge queue Aug 11, 2023
Merged via the queue into aws:develop with commit 13cce31 Aug 12, 2023
@mildaniel mildaniel deleted the warn-tfc-users branch August 12, 2023 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants