Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't run sam transform when getting (nested) stack information #5527

Merged
merged 5 commits into from
Jul 21, 2023

Conversation

mndeveci
Copy link
Contributor

Which issue(s) does this change fix?

#5432

Why is this change necessary?

In sam sync, when we are getting whole stack information by calling stacks = SamLocalStackProvider.get_stacks(self._template)[0], which runs SAMT automatically.

How does it address the issue?

With this change, we are adding use_sam_transform to SamLocaStackProvider.get_stacks so that we can list all stack information without running transform.

What side effects does this change have?

N/A

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mndeveci mndeveci requested a review from a team as a code owner July 14, 2023 21:15
@mndeveci mndeveci requested review from sriram-mv and hawflau July 14, 2023 21:15
Copy link
Contributor

@hnnasit hnnasit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the SAM-T transform be skipped for this function call as well https://github.com/aws/aws-sam-cli/blob/develop/samcli/lib/sync/watch_manager.py#L115?

@mndeveci
Copy link
Contributor Author

Can the SAM-T transform be skipped for this function call as well https://github.com/aws/aws-sam-cli/blob/develop/samcli/lib/sync/watch_manager.py#L115?

Thanks for catching that out, updated!

@mndeveci mndeveci added this pull request to the merge queue Jul 20, 2023
Merged via the queue into aws:develop with commit 49f22d5 Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants