Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use watch and code flags at the same time #4273

Merged
merged 8 commits into from
Oct 7, 2022

Conversation

mndeveci
Copy link
Contributor

@mndeveci mndeveci commented Oct 2, 2022

Why is this change necessary?

This change was requested to speed up development pace when using sam sync. Users want to skip any Infra Sync (CFN deployment) when they know there are no template changes or they don't want to sync their template changes yet and want to do a quick code sync.

How does it address the issue?

With this change, users now allowed to combine --watch flag and --code in sam sync command. When they are used in combination, sam sync will skip all Infra Sync (CFN deployment) actions to speed up development. Users have to run sam sync without --code flag to sync their template changes with their deployed stack.

What side effects does this change have?

With this new combination, template changes won't be synced with deployed stack. Users will be warned with a message to run the sam sync command without --code flag.

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added area/sync sam sync command pr/internal labels Oct 2, 2022
@mndeveci mndeveci marked this pull request as ready for review October 3, 2022 22:21
Copy link
Contributor

@hnnasit hnnasit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@mndeveci mndeveci enabled auto-merge (squash) October 7, 2022 00:21
@mndeveci mndeveci merged commit 4d75d4f into aws:develop Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/sync sam sync command pr/internal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants