Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix --docker-volume-basedir being ignored for sam local #4186

Merged
merged 10 commits into from
Sep 9, 2022

Conversation

lucashuy
Copy link
Contributor

@lucashuy lucashuy commented Sep 1, 2022

Which issue(s) does this change fix?

#2837

Why is this change necessary?

This changes fixes --docker-volume-basedir not being used to resolve a relative code URI in the template file. Previously, the code URI was automatically resolved to an absolute path, causing checks later on to ignore the directory passed by --docker-volume-basedir since the code URI had already been resolved.

How does it address the issue?

If the command flag is passed, the invoke context will set use_raw_codeuri=True to the function providers, making sure that the code URI stays relative until the end.

What side effects does this change have?

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added pr/external stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. labels Sep 1, 2022
@lucashuy lucashuy added area/docker area/local and removed stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. labels Sep 6, 2022
@lucashuy lucashuy requested review from a team, qingchm and hnnasit and removed request for a team September 8, 2022 21:00
@ffMathy
Copy link

ffMathy commented Jul 20, 2023

@hnnasit this has not been resolved. It is still an issue.

@grouu-tech
Copy link

+1 totally not fixed yet.

@ffMathy
Copy link

ffMathy commented Oct 20, 2023

Cc @lucashuy

@LinmeiJ
Copy link

LinmeiJ commented Nov 21, 2024

Not fixed...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants