Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: sam init changes to improve getting manifest time and clone messaging #3601

Merged
merged 5 commits into from
Feb 16, 2022
Merged

feat: sam init changes to improve getting manifest time and clone messaging #3601

merged 5 commits into from
Feb 16, 2022

Conversation

jonife
Copy link
Contributor

@jonife jonife commented Jan 25, 2022 •
edited
Loading

This pr addresses issues raised by customers with respect to new revamped SAM CLI Init interactive experience:

  1. In this PR the wait time to get the manifest file from the cli template was reduced by 80%. Additional robust fault tolerance has been added to ensure that customers always get a vended app template.
  2. CLl depends on the manifest file in the cli template repo to create the new, easy and quick interactive experience. This update in the PR ensures that the cli
    • Attempts to first get just the Manifest file directly from github
    • If this fails, the CLI then resorts to cloning the cli template repo and using the cloned manifest
    • if the cloning fails, a local manifest which acts as reference to all local app templates in SAM CLI is used.
      This way ensures that customers always have access to a vended serverless template.
  3. Finally, the new SAM CLI has the ability to filter through options therefore reducing the number of steps to a vended serverless application template via the interactive flow by at-most 70%. This PR adds a text/helper to help make customers aware of those preselected options.
  4. In this pr, the clone message displayed while cloning from github was improved to be more clear.

@jonife jonife requested a review from mndeveci January 25, 2022 21:01
mndeveci
mndeveci suggested changes Jan 27, 2022
View reviewed changes
@jonife jonife changed the title SAM INIT Revamp SAM INIT Changes to Improve getting manifest time and improve the clone message Feb 1, 2022
@mndeveci mndeveci changed the title SAM INIT Changes to Improve getting manifest time and improve the clone message feat: sam init changes to improve getting manifest time and clone messaging Feb 3, 2022
@jonife jonife force-pushed the init-cloning_update branch from 1f18fd5 to a067799 Compare February 16, 2022 00:26
@moelasmar moelasmar merged commit 520f68c into aws:develop Feb 16, 2022
mildaniel added a commit to mildaniel/aws-sam-cli that referenced this pull request Feb 18, 2022
@mildaniel
Revert "feat: sam init changes to improve getting manifest time and c…
c79ab04 
…lone messaging (aws#3601)"

This reverts commit 520f68c.
CoshUS added a commit that referenced this pull request Feb 18, 2022
@CoshUS
Revert "feat: sam init changes to improve getting manifest time and c…
1bbd057 
…lone messaging (#3601)"

This reverts commit 520f68c.
@mildaniel mildaniel mentioned this pull request Feb 18, 2022
Merged
mndeveci added a commit that referenced this pull request Feb 18, 2022
@mildaniel @CoshUS @mndeveci
Revert "feat: sam init changes to improve getting manifest time and c…
27f3ba2 
…lone messaging (#3601)" (#3665)

This reverts commit 520f68c.

Co-authored-by: Wilton_ <[email protected]>
Co-authored-by: Mehmet Nuri Deveci <[email protected]>
mndeveci added a commit that referenced this pull request Feb 19, 2022
@mndeveci
Revert "Revert "feat: sam init changes to improve getting manifest ti…
2db323a 
…me and clone messaging (#3601)" (#3665)"

This reverts commit 27f3ba2.
mildaniel added a commit that referenced this pull request Feb 19, 2022
@mndeveci @mildaniel
Revert "Revert "feat: sam init changes to improve getting manifest ti…
80eccbe 
…me and clone messaging (#3601)" (#3665)" (#3666)

This reverts commit 27f3ba2.

Co-authored-by: Daniel Mil <[email protected]>
mndeveci pushed a commit to mndeveci/aws-sam-cli that referenced this pull request Apr 5, 2022
@jonife @moelasmar @mndeveci
feat: sam init changes to improve getting manifest time and clone mes…
e7bed0c 
…saging (aws#3601)

* Improve wait time during interactive flow experience

* created static variable MANIFEST_URL

* Log messages resolution

Co-authored-by: Mohamed Elasmar <[email protected]>
mndeveci added a commit to mndeveci/aws-sam-cli that referenced this pull request Apr 5, 2022
@mildaniel @CoshUS @mndeveci
Revert "feat: sam init changes to improve getting manifest time and c…
49d6a42 
…lone messaging (aws#3601)" (aws#3665)

This reverts commit 520f68c.

Co-authored-by: Wilton_ <[email protected]>
Co-authored-by: Mehmet Nuri Deveci <[email protected]>
mndeveci added a commit to mndeveci/aws-sam-cli that referenced this pull request Apr 5, 2022
@mndeveci @mildaniel
Revert "Revert "feat: sam init changes to improve getting manifest ti…
0d9814f 
…me and clone messaging (aws#3601)" (aws#3665)" (aws#3666)

This reverts commit 27f3ba2.

Co-authored-by: Daniel Mil <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mndeveci mndeveci mndeveci approved these changes

@moelasmar moelasmar moelasmar approved these changes

Assignees
No one assigned
Labels
area/init sam init pr/external
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonife @mndeveci @moelasmar