fix: adl layer sync fixes #3367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- skip adl layer sync if dependencies are not changed. - find physical id of adl layer. - collect related functions for a layer change
CoshUS
reviewed
Oct 18, 2021
CoshUS
approved these changes
Oct 19, 2021
qingchm
reviewed
Oct 20, 2021
| @@ -347,6 +347,7 @@ def _compare_hash_changes( | |||
| uuid = stored_def.uuid | |||
| if old_hash != updated_hash or old_manifest_hash != updated_manifest_hash: | |||
| content[uuid] = BuildHashingInformation(updated_hash, updated_manifest_hash) | |||
| compared_def.download_dependencies = old_manifest_hash != updated_manifest_hash | |||
There was a problem hiding this comment.
Are we not storing this back to our build.toml file?
There was a problem hiding this comment.
Nope, download_dependencies are not stored in build.toml file. Can be seen here;
aws-sam-cli/samcli/lib/build/build_graph.py
Line 482 in bff4f6e
qingchm
approved these changes
Oct 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.