Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Building a provided layer outside a container #3328 #3330

Merged
merged 4 commits into from
Oct 19, 2021

Conversation

valerena
Copy link
Contributor

@valerena valerena commented Oct 1, 2021

Which issue(s) does this change fix?

#3328

Why is this change necessary?

How does it address the issue?

Undo changes that affected building outside of a container.

What side effects does this change have?

Checklist

  • Add input/output type hints to new functions/methods
  • Write design document (Do I need to write a design document?)
  • Write unit tests
  • Write/update functional tests
  • Write/update integration tests
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mgrandis mgrandis changed the title fix: #3328 fix: Building a provided layer outside a container #3328 Oct 1, 2021
@hawflau hawflau merged commit 8cfeed7 into aws:develop Oct 19, 2021
qingchm added a commit that referenced this pull request Oct 21, 2021
* fix: Building a provided layer outside a container #3328 (#3330)

* fix: #3328

* fix: Get back old message too

* Fix line length

Co-authored-by: Mehmet Nuri Deveci <[email protected]>

* Update to pin regex to 2021.9.30 due to 2021.10.8 not working on M1 Mac (#3373)

* Update to pin regex to 2021.9.30 due to 2021.10.8 not working on M1 Mac

* Pin tzlocal 3.0

* Update note about pinning tzlocal to 3.0

* fix RequestContextV2 to return same fields as real Lambda service (#3308)

* fix RequestContextV2 to return same fields as real Lambda service

* add comment and fix

* fix tests

* RequestContextV2 stage has a default value

* move stage name default up into root level constructor

* set to default in to_dict

Co-authored-by: Wing Fung Lau <[email protected]>

* ci: increase default process timeout for tests and update image validation after build (#3374)

* increase default process timeout for tests and update image validation after build

* add images information to assertion message

* fix: update tag checking and replace "verify_pulling_only_latest_tag" with "verify_pulled_image"

* fix: update pyinstaller build-linux.sh file to successfully build native executable (#3355)

Co-authored-by: Mehmet Nuri Deveci <[email protected]>

Co-authored-by: Renato Valenzuela <[email protected]>
Co-authored-by: Mehmet Nuri Deveci <[email protected]>
Co-authored-by: Wing Fung Lau <[email protected]>
Co-authored-by: Vince Pergolizzi <[email protected]>
Co-authored-by: Jack <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants