feat: Sam init interactive flow redesign #3235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgrandis
changed the title
mgrandis
approved these changes
Sep 2, 2021
|
@jonife does this have 95% unit test coverage? because the appveyor.yml references 94% however |
|
it should be 95% now |
sriram-mv
approved these changes
Sep 3, 2021
CoshUS
approved these changes
Sep 10, 2021
mgrandis
added a commit
that referenced
this pull request
Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
Why is this change necessary?
The changes made in this pr was to take into account 2 things listed below:
1: Add Sorting the list of dependency manager: This was aimed at getting a consistent order in the list option for dependency manager, as against an ever changing order in the option for dependency while using only a set. This update was done in
samcli/commands/init/interactive_init_flow.py2: Updated the Init Integration test: Due to recent UX changes to SAM init, which affected the way the the init integration test previously simulated the user input and as such the integration test needed to be updated to simulate the current flow. This update was done in
tests/integration/init/schemas/test_init_with_schemas_command.pyandtests/integration/init/schemas/schemas_test_data_setup.py