Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Revert Init Redesign #3225

Merged
merged 2 commits into from
Sep 1, 2021
Merged

Conversation

CoshUS
Copy link
Contributor

@CoshUS CoshUS commented Sep 1, 2021

Revert for PRs: #2958 and #3211

Following are some of the issues preventing release:

  1. All integration tests in samcli\commands\init\interactive_init_flow.py are broken. Prompts are not matching inputs thus hanging process.
  2. Using set for listing dependency managers will cause undetermined ordering
valid_dep_managers = (
        RUNTIME_TO_DEPENDENCY_MANAGERS.get(runtime)
        if not options
        else list(set(template["dependencyManager"] for template in options))
    )

Let's run and pass all integration tests before merge in future PRs.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@CoshUS CoshUS requested review from sriram-mv and mgrandis September 1, 2021 06:36
@CoshUS CoshUS merged commit 4fa89fe into aws:develop Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants