Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix regression test cases in Python 3.9 #3183

Merged
merged 8 commits into from
Aug 19, 2021
Merged

fix: Fix regression test cases in Python 3.9 #3183

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9dd099d
chore: bump version to 1.29.0
moelasmar Aug 18, 2021
091048c
fix the signed deploy use cases. The Created bucket should be versioned
moelasmar Aug 18, 2021
dc82345
Merge remote-tracking branch 'aws-sam-cli-public/develop' into develop
moelasmar Aug 18, 2021
bd403b3
fix the python 3.9 regression test cases failure.
moelasmar Aug 19, 2021
725705c
Merge remote-tracking branch 'aws-sam-cli-public/develop' into develop
moelasmar Aug 19, 2021
4b74936
fix the python 3.9 regression test cases failure.
moelasmar Aug 19, 2021
328cf9f
fix the python 3.9 regression test cases failure.
moelasmar Aug 19, 2021
3477583
run black
moelasmar Aug 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions tests/regression/package/regression_package_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@

import boto3

from samcli.yamlhelper import yaml_parse

S3_SLEEP = 3
TIMEOUT = 300

Expand Down Expand Up @@ -108,8 +110,14 @@ def regression_check(self, args):
self.assertEqual(process.returncode, 0)
output_aws = output_template_file_aws.read()

# remove the region name from the template url in cases like nested stacks
output_aws = output_aws.replace(b"s3.us-east-1.", b"s3.")

if "use_json" in args and args.get("use_json"):
output_sam = json.loads(output_sam)
output_aws = json.loads(output_aws)
else:
output_sam = yaml_parse(output_sam)
output_aws = yaml_parse(output_aws)

self.assertEqual(output_sam, output_aws)