Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix the signing integration test cases by creating the S3 Buckets with versioning enabled #3182

Merged
merged 3 commits into from
Aug 18, 2021

Conversation

moelasmar
Copy link
Contributor

Which issue(s) does this change fix?

Why is this change necessary?

How does it address the issue?

What side effects does this change have?

Checklist

  • Add input/output type hints to new functions/methods
  • Write design document (Do I need to write a design document?)
  • Write unit tests
  • Write/update functional tests
  • Write/update integration tests
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@moelasmar moelasmar merged commit c65cb05 into aws:develop Aug 18, 2021
@moelasmar moelasmar changed the title Fix the signing integration test cases by creating the S3 Buckets with versioning enabled fix: Fix the signing integration test cases by creating the S3 Buckets with versioning enabled Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants