Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sam validate with local image #2892

Merged
merged 6 commits into from
Aug 24, 2021
Merged

fix: sam validate with local image #2892

merged 6 commits into from
Aug 24, 2021

Conversation

hoffa
Copy link
Contributor

@hoffa hoffa commented May 20, 2021

Which issue(s) does this change fix?

#2893
#2613

Why is this change necessary?

How does it address the issue?

Create fake ImageUri when the image is referenced locally.

What side effects does this change have?

Tested with:

SAM_CLI_TELEMETRY=0 make func-test

Checklist

  • Add input/output type hints to new functions/methods
  • Write design document (Do I need to write a design document?)
  • Write unit tests
  • Write/update functional tests
  • Write/update integration tests
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hoffa hoffa marked this pull request as ready for review May 21, 2021 04:51
Copy link
Contributor

@aahung aahung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants