chore: Make methods that do not need to be instance methods static #2525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aahung
changed the title
elbayaaa
reviewed
Jan 8, 2021
Comment on lines
-44
to
+52
| build_strategy = BuildStrategy(self.build_graph) | ||
| build_strategy = _TestBuildStrategy(self.build_graph) |
There was a problem hiding this comment.
would you explain why we need this "_TestBuildStrategy" class?
There was a problem hiding this comment.
BuildStrategy is an abstract class so I need to create a subclass to instantiate an object.
There was a problem hiding this comment.
(and adding prefix _ to indicate it is a "private" class)
elbayaaa
approved these changes
Jan 8, 2021
aahung
force-pushed
the
add-static-decorators
branch
from
b97d294 to
1c59bf1
Compare
|
(manually rebase the latest develop to resolve the conflict) |
|
Added type hints except for ones requiring a lot effort |
CoshUS
approved these changes
Jan 18, 2021
elbayaaa
approved these changes
Jan 18, 2021
mndeveci
pushed a commit
to mndeveci/aws-sam-cli
that referenced
this pull request
Jan 19, 2021
…ws#2525) * chore: Make instance methods that do not need to be instance methods static * Add type hints to methods touched * Merge develop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…static
Which issue(s) does this change fix?
Why is this change necessary?
There are many instance methods do not need to be instance methods since
selfis not being used. Making it static increases readability.How does it address the issue?
Making them static. One exception, for
BuildStrategy, the class is meant to be an abstract class, so I made its two instance methods abstract instead of static.What side effects does this change have?
no,
We don't need to change how we invoke them.
Checklist
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.