chore: Bump SAM CLI install version for Actions #459
Conversation
lucashuy
requested review from
hnnasit and
sidhujus
and removed request for
a team
|
A dynamic import is used somewhere in SAM CLI or one of its deps that is causing issues with newer versions (>=3.10) of Python (ref: aws/aws-sam-cli#6143). I initially set it as 3.11, but dropped the version to 3.8 for now. We could merge in the other PR, then bump it back to 3.11 here, or we could merge this first, should be an easy enough change in the future to bump it back to 3.11. |
| @@ -101,15 +101,15 @@ jobs: | |||
| type: 'Invoke' | |||
| file: 'tests/integration/build_invoke/python/test_python_3_11.py' | |||
| env: | |||
| PYTHON_VERSION_INSTALL: ${{ matrix.version }} | |||
| PYTHON_VERSION_INSTALL: 3.8 | |||
There was a problem hiding this comment.
I wonder if this is redundant since we have the same env var defined at the root scope.
There was a problem hiding this comment.
Thats a good point, will remove this since this was used before to install SAM CLI with the same version that was testing the runtime
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| name: Checkout PR | ||
| - uses: ./.github/actions/aws-sam-cli-develop | ||
| name: Install develop version of AWS SAM CLI | ||
| env: | ||
| PYTHON_VERSION_INSTALL: ${{ matrix.version }} | ||
| PYTHON_VERSION_INSTALL: 3.8 |
There was a problem hiding this comment.
same as above. could be redundant
Issue #, if available:
None.
Description of changes:
Bumps the minimum version of Python that is used to install SAM CLI from source in the actions.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.