Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): avoid vulnerable [email protected] #430

Merged
merged 2 commits into from
May 18, 2021

Conversation

ddneilson
Copy link
Contributor

@ddneilson ddneilson commented May 17, 2021

Eliminates risk from GHSA-43f8-2h32-f4cj

The package in question is used as a dev dependency in our repository; specifically as transitive dependencies from [email protected] and [email protected]. These are the latest versions of these packages. As a dev dependency, the risk of this CVE is super low -- at worst it's a developer's build taking a little longer than desired. But, better to be safe than sorry.

Changes to our dependency tree

Before

[email protected]
├─┬ [email protected]
│ ├─┬ [email protected]
│ │ └─┬ [email protected]
│ │   ├─┬ [email protected]
│ │   │ ├── [email protected] 
│ │   │ └─┬ [email protected]
│ │   │   └── [email protected]  deduped
│ │   ├─┬ [email protected]
│ │   │ └─┬ [email protected]
│ │   │   └─┬ [email protected]
│ │   │     └── [email protected] 
│ │   └─┬ [email protected]
│ │     └── [email protected] 
│ └─┬ [email protected]
│   ├─┬ [email protected]
│   │ └── [email protected] 
│   └─┬ [email protected]
│     └─┬ [email protected]
│       └─┬ [email protected]
│         └── [email protected] 
└─┬ [email protected]
  ├─┬ @lerna/[email protected]
  │ └─┬ [email protected]
  │   └── [email protected] 
  ├─┬ @lerna/[email protected]
  │ └─┬ [email protected]
  │   └─┬ [email protected]
  │     └─┬ [email protected]
  │       └── [email protected] 
  ├─┬ @lerna/[email protected]
  │ └─┬ @lerna/[email protected]
  │   └─┬ [email protected]
  │     └─┬ [email protected]
  │       └── [email protected] 
  └─┬ @lerna/[email protected]
    └─┬ @lerna/[email protected]
      └─┬ [email protected]
        └─┬ [email protected]
          └── [email protected] 

After

[email protected]
├─┬ [email protected]
│ ├─┬ [email protected]
│ │ └─┬ [email protected]
│ │   ├─┬ [email protected]
│ │   │ ├── [email protected] 
│ │   │ └─┬ [email protected]
│ │   │   └── [email protected]  deduped
│ │   ├─┬ [email protected]
│ │   │ └─┬ [email protected]
│ │   │   └─┬ [email protected]
│ │   │     └── [email protected] 
│ │   └─┬ [email protected]
│ │     └── [email protected] 
│ └─┬ [email protected]
│   ├─┬ [email protected]
│   │ └── [email protected] 
│   └─┬ [email protected]
│     └─┬ [email protected]
│       └─┬ [email protected]
│         └── [email protected] 
└─┬ [email protected]
  ├─┬ @lerna/[email protected]
  │ └─┬ [email protected]
  │   └── [email protected] 
  ├─┬ @lerna/[email protected]
  │ └─┬ [email protected]
  │   └─┬ [email protected]
  │     └─┬ [email protected]
  │       └── [email protected] 
  ├─┬ @lerna/[email protected]
  │ └─┬ @lerna/[email protected]
  │   └─┬ [email protected]
  │     └─┬ [email protected]
  │       └── [email protected] 
  └─┬ @lerna/[email protected]
    └─┬ @lerna/[email protected]
      └─┬ [email protected]
        └─┬ [email protected]
          └── [email protected] 

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

jericht
jericht previously approved these changes May 17, 2021
Copy link
Contributor

@jusiskin jusiskin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job leaving a breadcrumb trail for future cleanup!

@jusiskin jusiskin merged commit 2da01e5 into aws:mainline May 18, 2021
@ddneilson ddneilson deleted the hosted-git-info branch July 28, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants