add log-level helm param #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haugenj
reviewed
Dec 10, 2020
| @@ -76,6 +76,9 @@ taintNode: false | |||
| # Log messages in JSON format. | |||
| jsonLogging: false | |||
|
|
|||
| # Sets the log level | |||
| logLevel: "info" | |||
There was a problem hiding this comment.
should we leave this as "" ?
There was a problem hiding this comment.
My thought is it's easier to figure out the default value this way.
If we leave it as "" , then helm readme would have default value say "" too (even though app will default to 'info') OR we have the helm default value actually say info, but then the value in values.yaml would be "" and not match which is confusing/doesn't align with how we documented other vals.
haugenj
pushed a commit
to haugenj/aws-node-termination-handler
that referenced
this pull request
Dec 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Testing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.