Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kube version helm #190

Merged
merged 3 commits into from
Jul 7, 2020
Merged

Kube version helm #190

merged 3 commits into from
Jul 7, 2020

Conversation

bwagner5
Copy link
Contributor

@bwagner5 bwagner5 commented Jul 7, 2020

Issue #, if available:
N/A

Description of changes:

  • Change helm helper kube-version retrieval to use Major/Minor instead of Version since it's supported in helm v2 and v3
  • Add helm v2 and v3 linting to travis

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@bwagner5 bwagner5 requested a review from cjerad July 7, 2020 16:10
@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2020

Codecov Report

Merging #190 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #190   +/-   ##
=======================================
  Coverage   81.26%   81.26%           
=======================================
  Files          10       10           
  Lines         774      774           
=======================================
  Hits          629      629           
  Misses        129      129           
  Partials       16       16           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6cbb2a...f2e8e8b. Read the comment docs.

Copy link
Member

@cjerad cjerad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

@cjerad cjerad merged commit e16065c into aws:master Jul 7, 2020
@bwagner5 bwagner5 deleted the kube-version-helm branch July 15, 2020 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants