Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata endpoint and Kiam documentation #188

Merged
merged 1 commit into from
Jul 6, 2020

Conversation

leosunmo
Copy link
Contributor

@leosunmo leosunmo commented Jul 2, 2020

Issue #, if available: #187

Description of changes:
This adds documentation on which EC2 metadata endpoints the termination handler relies on.
It also provides a config option to enable the termination handler to function properly on a cluster that has Kiam deployed to manage AWS IAM credentials.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

This adds documentation on which EC2 metadata endpoints the termination
handler relies on.
It also provides a config option to enable the termination handler to
function properly on a cluster that has Kiam deployed to manage AWS IAM
credentials.
@codecov-commenter
Copy link

codecov-commenter commented Jul 3, 2020

Codecov Report

Merging #188 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #188   +/-   ##
=======================================
  Coverage   81.30%   81.30%           
=======================================
  Files           8        8           
  Lines         765      765           
=======================================
  Hits          622      622           
  Misses        128      128           
  Partials       15       15           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8cce3e...9ce8b07. Read the comment docs.

Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this!!

@bwagner5 bwagner5 merged commit 049947c into aws:master Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants