handle http proxy config for webhooks #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haugenj
reviewed
May 5, 2020
Comment on lines
87
to
88
|
|
||
|
|
bwagner5
force-pushed
the
http-proxy
branch
5 times, most recently
from
2622df1 to
6ab2885
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#144
Description of changes:
Add support to proxy webhooks. This does not proxy kubernetes API requests or http calls to the EC2 Instance Metadata Service.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.